...
| comment # | Line/Reference # | Proposed Change or Query | Proposer / Affiliation | Action / Decision (please leave blank) |
|---|---|---|---|---|
| 1 | 161 | The issues regarding Peter: Seems many more things from that page and its comment(s) have not been considered, 5 years (!) after they had been written. | Thomas Lenggenhager / SWITCH | We will adjust the references and address several of the 1.5.0 issues. We're not clear on what to do with urn:schac:homeOrganizationType:eu:higherEducationalInstitution and urn:schac:homeOrganizationType:eu:educationalInstitution as those examples do match what's in the spec. |
| 2 | - | Better than referring to ISO-3166-2 would be to refer to ISO 3166-1 alpha-2 as in the European Student Identifier spec. | Thomas Lenggenhager / SWITCH | This makes sense. Will fix. |
| 3 | 185 | Adding a European Student Identifier example for schacPersonalUniqueCode would make sense. | Thomas Lenggenhager / SWITCH | This makes sense. Will fix. |
| 4 | 7,28,235,615 and page footer(s) | Does deprecating an unused attribute and updating references to the TERENA website justify going from 1.5.0 to 1.6.0? To me that feels more like a 1.5.1, at least going by gut feeling (not by seriously trying to apply semver). The fact that plenty of other issues that were reported years ago (e.g. those mentioned in comment #1 above) have not been dealt with makes this release even less convincing. | Deprecating an attribute, while not a breaking change, is a significant enough action to require a minor number change. If we were introducing a breaking change (i.e., removing the attribute entirely) then we'd want to change this to 2.0. If we were only changing references to the TERENA website, that would be just the patch number update. | |