...
| Number | Line / Reference | Proposed Change or Query | Proposer |
|---|---|---|---|
| 1 | General | I like the use of Entity Attributes but I think the use of a raw base64-encoded blob of JSON is not the best way to include the Entity Selection filter in metadata. I would suggest two changes: 1) Require the value to be a URL, either a link to the Entity Selection data as a remote file, or a data: URL embedding the selection filter directly into the metadata. - Both allow the use of different formats in the future via MIME types A downside to selection filters at arbitrary remote URLs is that they lack the level of trust possible with data embedded in federation metadata. If this is a critical requirement I suggest either limiting the values to data: URLs, or hosting the remote filter files at the federation alongside the metadata. 2) Allow multiple values - Allows the consuming service to choose the most suitable filter format These changes also make it easier to define the initial filter format specification because it is no longer so tightly coupled to the metadata. | Pete Birkinshaw, Mimoto |
| 2 | General | In the document, I don't see any example of selecting individual IdPs within a specific federation. Is this intentional, or should it also be possible to select individual IdPs to be shown in the Discovery Service? If I understand correctly, the document only illustrates how to select individual Registration Authorities, but Service Providers often need to restrict access to institutions with which they have signed an agreement, these may belong to multiple federations. If we only allow displaying or hiding all institutions within one or more Registration Authorities, services will not be able to use this EntityAttribute to show only those institutions with which a contract has been activated. If selecting individual IdPs per federation is allowed, could a proper example be added to the specification? | |
| 3 | Line 47 | Will guidelines be provided to help provide a consistent semantics of the decoded values for metadata consumers? For example, if Seamless access has guidelines for use with their discovery service can these be referenced in an FAQ so all implementations of discovery will respond consistently? | |
| 4 | Lines 51 thru 53 | Will there be a verification or test tool or example of such that will provide a warning if the decoded value does not conform? |